Skip to content

Commit

Permalink
Add db_name parameter at bulk_import (#2446)
Browse files Browse the repository at this point in the history
The purpose of this PR is to align the parameter passing in the Python
SDK with the RESTful API, and to add the missing "dbName" field.

see:
https://milvus.io/api-reference/restful/v2.4.x/v2/Import%20(v2)/Create.md

> dbName
string
The name of the database that to which the collection belongs . Setting
this to a non-existing database results in an error.

Signed-off-by: counter2015 <[email protected]>
  • Loading branch information
counter2015 authored Dec 30, 2024
1 parent 8369957 commit 67a6cca
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pymilvus/bulk_writer/bulk_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def _get_request(
def bulk_import(
url: str,
collection_name: str,
db_name: str = "default",
files: Optional[List[List[str]]] = None,
object_url: str = "",
cluster_id: str = "",
Expand All @@ -91,6 +92,7 @@ def bulk_import(
Args:
url (str): url of the server
collection_name (str): name of the target collection
db_name (str): name of target database
partition_name (str): name of the target partition
files (list of list of str): The files that contain the data to import.
A sub-list contains a single JSON or Parquet file, or a set of Numpy files.
Expand All @@ -110,6 +112,7 @@ def bulk_import(
partition_name = kwargs.pop("partition_name", "")
params = {
"collectionName": collection_name,
"dbName": db_name,
"partitionName": partition_name,
"files": files,
"objectUrl": object_url,
Expand Down

0 comments on commit 67a6cca

Please sign in to comment.