Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4]Return collection not loaded rather than not found on querynode (#38593) #38920

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from

Conversation

xiaocai2333
Copy link
Contributor

issue: #38586

master pr: #38593

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.45%. Comparing base (a3ea66f) to head (c69c5e4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38920      +/-   ##
==========================================
+ Coverage   72.18%   79.45%   +7.27%     
==========================================
  Files        1077     1077              
  Lines      169575   169575              
==========================================
+ Hits       122402   134731   +12329     
+ Misses      42694    30357   -12337     
- Partials     4479     4487       +8     
Files with missing lines Coverage Δ
internal/querynodev2/services.go 86.44% <100.00%> (-0.39%) ⬇️

... and 247 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants