Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Fix standby mixcoord start failed #38914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

When standby transitions to active, the component state changes to Initialize. If the initialization takes too long (exceeding the liveness probe's maximum retries), the standby pod is stopped and fails to start.
This PR removes the Initialize state during standby transitions in rolling upgrades. The state now switches directly from standby to healthy, preventing health check failures.

issue: #37630

pr: #38308

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 1, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign liliu-z after the PR has been reviewed.
You can assign the PR to them by writing /assign @liliu-z in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (accfacf) to head (4c1004d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38914      +/-   ##
==========================================
- Coverage   81.13%   81.10%   -0.03%     
==========================================
  Files        1385     1385              
  Lines      196070   196074       +4     
==========================================
- Hits       159083   159035      -48     
- Misses      31397    31436      +39     
- Partials     5590     5603      +13     
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.45% <ø> (-0.02%) ⬇️
Go 83.07% <100.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.31% <100.00%> (+0.09%) ⬆️
internal/querycoordv2/server.go 79.19% <100.00%> (+0.02%) ⬆️
internal/rootcoord/root_coord.go 88.10% <100.00%> (ø)

... and 27 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants