Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Skip creating partition rate limiters when not enable #38911

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

issue: #37630

pr: #38816

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jan 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (6fa096e) to head (5084800).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38911      +/-   ##
==========================================
- Coverage   81.05%   81.04%   -0.02%     
==========================================
  Files        1383     1383              
  Lines      195503   195512       +9     
==========================================
- Hits       158472   158448      -24     
- Misses      31457    31490      +33     
  Partials     5574     5574              
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (-0.02%) ⬇️
Go 83.02% <100.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/rootcoord/quota_center.go 82.99% <100.00%> (+0.69%) ⬆️

... and 38 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants