Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Optimize GetLocalDiskSize and segment loader mutex #38907

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. Make the segment loader lock protect only the resource.
  2. Optimize GetDiskUsage to avoid excessive overhead.

issue: #37630

pr: #38599

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.05%. Comparing base (6fa096e) to head (e64e083).

Files with missing lines Patch % Lines
...nternal/querynodev2/segments/disk_usage_fetcher.go 84.84% 4 Missing and 1 partial ⚠️
internal/querynodev2/segments/segment_loader.go 93.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38907      +/-   ##
==========================================
- Coverage   81.05%   81.05%   -0.01%     
==========================================
  Files        1383     1384       +1     
  Lines      195503   195533      +30     
==========================================
+ Hits       158472   158480       +8     
- Misses      31457    31482      +25     
+ Partials     5574     5571       -3     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.45% <ø> (-0.02%) ⬇️
Go 83.03% <89.83%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/querynodev2/segments/segment.go 64.15% <ø> (-0.15%) ⬇️
internal/querynodev2/server.go 77.86% <100.00%> (ø)
internal/util/segcore/cgo_util.go 88.46% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.39% <100.00%> (+<0.01%) ⬆️
internal/querynodev2/segments/segment_loader.go 72.87% <93.33%> (+0.08%) ⬆️
...nternal/querynodev2/segments/disk_usage_fetcher.go 84.84% <84.84%> (ø)

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants