Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] Fix slow dist handle and slow observe #38905

Open
wants to merge 7 commits into
base: 2.5
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Jan 1, 2025

  1. Provide partition&channel level indexing in the collection target.
  2. Make SegmentAction not wait for distribution.
  3. Remove scheduler and target manager mutex
  4. Optimize logging to reduce CPU overhead.

issue: #37630

pr: #38566

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 1, 2025
@sre-ci-robot sre-ci-robot requested a review from aoiasd January 1, 2025 08:51
@mergify mergify bot added the dco-passed DCO check passed. label Jan 1, 2025
@sre-ci-robot sre-ci-robot requested a review from congqixia January 1, 2025 08:51
@mergify mergify bot added the kind/bug Issues or changes related a bug label Jan 1, 2025
Copy link

codecov bot commented Jan 1, 2025

Codecov Report

Attention: Patch coverage is 89.49580% with 25 lines in your changes missing coverage. Please review.

Project coverage is 82.86%. Comparing base (055cbe1) to head (142ac44).

Files with missing lines Patch % Lines
internal/querycoordv2/task/scheduler.go 84.96% 18 Missing and 2 partials ⚠️
...rnal/querycoordv2/observers/collection_observer.go 83.33% 4 Missing ⚠️
internal/querycoordv2/meta/target.go 98.24% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #38905       +/-   ##
===========================================
+ Coverage   69.45%   82.86%   +13.40%     
===========================================
  Files         294     1089      +795     
  Lines       26419   169066   +142647     
===========================================
+ Hits        18349   140091   +121742     
- Misses       8070    23403    +15333     
- Partials        0     5572     +5572     
Components Coverage Δ
Client 78.26% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.03% <89.49%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/dist/dist_handler.go 96.13% <100.00%> (ø)
internal/querycoordv2/meta/target_manager.go 86.93% <100.00%> (ø)
internal/querycoordv2/task/action.go 96.66% <100.00%> (ø)
internal/querycoordv2/utils/util.go 85.54% <100.00%> (ø)
internal/querynodev2/services.go 86.38% <100.00%> (ø)
pkg/metrics/querycoord_metrics.go 100.00% <ø> (ø)
internal/querycoordv2/meta/target.go 92.94% <98.24%> (ø)
...rnal/querycoordv2/observers/collection_observer.go 86.52% <83.33%> (ø)
internal/querycoordv2/task/scheduler.go 87.01% <84.96%> (ø)

... and 1374 files with indirect coverage changes

@mergify mergify bot removed the ci-passed label Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 2, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 3, 2025
@mergify mergify bot removed the ci-passed label Jan 3, 2025
Copy link
Contributor

mergify bot commented Jan 3, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 3, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants