Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expression with capital AND and OR are not recognized #38899

Closed
wants to merge 1 commit into from

Conversation

xiaofan-luan
Copy link
Collaborator

fix #38864
AND, OR and NOT is not recognized in milvus parser

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 1, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the dco-passed DCO check passed. label Jan 1, 2025
Copy link
Contributor

mergify bot commented Jan 1, 2025

@xiaofan-luan

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Jan 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.12%. Comparing base (95c1ccc) to head (1a8b897).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38899       +/-   ##
===========================================
+ Coverage   69.45%   81.12%   +11.66%     
===========================================
  Files         294     1385     +1091     
  Lines       26430   196070   +169640     
===========================================
+ Hits        18357   159058   +140701     
- Misses       8073    31419    +23346     
- Partials        0     5593     +5593     
Components Coverage Δ
Client 79.12% <ø> (∅)
Core 69.45% <ø> (ø)
Go 83.09% <ø> (∅)

see 1091 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 1, 2025
@xiaofan-luan
Copy link
Collaborator Author

@yanliang567
please help on testing AND, OR and NOT keyword

@xiaofan-luan xiaofan-luan changed the title Fix capital expression not recognoized fix: expression with capital AND and OR are not recognized Jan 1, 2025
@mergify mergify bot added the kind/bug Issues or changes related a bug label Jan 1, 2025
Copy link
Contributor

@xiaocai2333 xiaocai2333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to regenerate the parsing files according to the new rule files. You can refer to https://github.com/milvus-io/milvus/tree/master/internal/parser/planparserv2#readme.

@xiaocai2333
Copy link
Contributor

track in PR #38927

@czs007 czs007 closed this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Query filter with JSON: "AND" not working, must be "&&" (documentation issue?)
4 participants