-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: expression with capital AND and OR are not recognized #38899
Conversation
Signed-off-by: xiaofanluan <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #38899 +/- ##
===========================================
+ Coverage 69.45% 81.12% +11.66%
===========================================
Files 294 1385 +1091
Lines 26430 196070 +169640
===========================================
+ Hits 18357 159058 +140701
- Misses 8073 31419 +23346
- Partials 0 5593 +5593
|
@yanliang567 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to regenerate the parsing files according to the new rule files. You can refer to https://github.com/milvus-io/milvus/tree/master/internal/parser/planparserv2#readme.
track in PR #38927 |
fix #38864
AND, OR and NOT is not recognized in milvus parser