Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support phrase match query #38869

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

SpadeA-Tang
Copy link
Contributor

@SpadeA-Tang SpadeA-Tang commented Dec 31, 2024

The relevant issue: #38930

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 31, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@SpadeA-Tang Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@SpadeA-Tang SpadeA-Tang marked this pull request as draft December 31, 2024 04:07
@sre-ci-robot sre-ci-robot added the do-not-merge/work-in-progress Don't merge even CI passed. label Dec 31, 2024
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
@SpadeA-Tang SpadeA-Tang marked this pull request as ready for review January 2, 2025 05:45
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Jan 2, 2025
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Signed-off-by: SpadeA-Tang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@SpadeA-Tang
Copy link
Contributor Author

rerun go-sdk

Signed-off-by: SpadeA-Tang <[email protected]>
Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 73.75000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 81.15%. Comparing base (907fc24) to head (7e0686e).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/parser/planparserv2/parser_visitor.go 70.96% 6 Missing and 3 partials ⚠️
internal/core/src/expr/ITypeExpr.h 45.45% 6 Missing ⚠️
internal/core/src/exec/expression/UnaryExpr.cpp 76.47% 4 Missing ⚠️
internal/core/src/index/TextMatchIndex.cpp 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38869       +/-   ##
===========================================
+ Coverage   69.54%   81.15%   +11.61%     
===========================================
  Files         296     1387     +1091     
  Lines       26535   196343   +169808     
===========================================
+ Hits        18454   159346   +140892     
- Misses       8081    31416    +23335     
- Partials        0     5581     +5581     
Components Coverage Δ
Client 79.12% <ø> (∅)
Core 69.55% <72.72%> (+<0.01%) ⬆️
Go 83.12% <75.00%> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/EasyAssert.h 84.61% <ø> (ø)
internal/core/src/query/PlanProto.cpp 89.01% <100.00%> (+0.22%) ⬆️
internal/parser/planparserv2/show_visitor.go 94.11% <100.00%> (ø)
internal/core/src/index/TextMatchIndex.cpp 42.68% <77.77%> (+2.03%) ⬆️
internal/core/src/exec/expression/UnaryExpr.cpp 84.23% <76.47%> (-0.36%) ⬇️
internal/core/src/expr/ITypeExpr.h 45.91% <45.45%> (-0.22%) ⬇️
internal/parser/planparserv2/parser_visitor.go 86.07% <70.96%> (ø)

... and 1090 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/feature Issues related to feature request from users size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants