Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: erase the rpc level when wal is located at same node #38858

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 30, 2024

issue: #38399

  • Make the wal scanner interface same with streaming scanner.
  • Use wal if the wal is located at current node.
  • Otherwise fallback the old logic.

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Dec 30, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 30, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 77.76333% with 171 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (dd81a13) to head (f4cbd43).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
...ernal/querycoordv2/balance/multi_target_balance.go 0.00% 34 Missing ⚠️
...al/querycoordv2/balance/rowcount_based_balancer.go 70.58% 10 Missing and 5 partials ⚠️
internal/querycoordv2/ops_services.go 23.52% 9 Missing and 4 partials ⚠️
...treamingnode/client/handler/handler_client_impl.go 78.84% 7 Missing and 4 partials ⚠️
pkg/streaming/util/message/adaptor/handler.go 80.35% 8 Missing and 3 partials ⚠️
...erycoordv2/balance/channel_level_score_balancer.go 18.18% 8 Missing and 1 partial ⚠️
...ternal/querycoordv2/meta/replica_manager_helper.go 82.35% 8 Missing and 1 partial ⚠️
internal/querycoordv2/server.go 12.50% 5 Missing and 2 partials ⚠️
...l/interceptors/segment/manager/pchannel_manager.go 56.25% 7 Missing ⚠️
...dv2/balance/streaming_query_node_channel_helper.go 85.00% 4 Missing and 2 partials ⚠️
... and 15 more
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #38858    +/-   ##
========================================
  Coverage   81.12%   81.12%            
========================================
  Files        1385     1388     +3     
  Lines      195922   196778   +856     
========================================
+ Hits       158939   159641   +702     
- Misses      31396    31530   +134     
- Partials     5587     5607    +20     
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.54% <ø> (+0.08%) ⬆️
Go 83.08% <77.73%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
...buted/streaming/internal/consumer/consumer_impl.go 88.14% <100.00%> (-0.09%) ⬇️
...distributed/streaming/internal/consumer/handler.go 100.00% <100.00%> (ø)
...ted/streaming/internal/consumer/message_handler.go 100.00% <100.00%> (ø)
...istributed/streaming/internal/producer/producer.go 89.91% <100.00%> (+4.20%) ⬆️
internal/distributed/streamingnode/service.go 68.13% <ø> (-0.12%) ⬇️
...ernal/querycoordv2/balance/score_based_balancer.go 98.78% <100.00%> (+0.07%) ⬆️
internal/querycoordv2/checkers/channel_checker.go 87.35% <100.00%> (+0.22%) ⬆️
internal/querycoordv2/meta/replica.go 100.00% <100.00%> (ø)
internal/querycoordv2/session/node_manager.go 100.00% <100.00%> (ø)
...nal/streamingcoord/client/assignment/discoverer.go 91.08% <100.00%> (+1.20%) ⬆️
... and 33 more

... and 59 files with indirect coverage changes

chyezh added 2 commits January 2, 2025 11:01
Signed-off-by: chyezh <[email protected]>
- Make the wal scanner interface same with streaming scanner.
- Use wal if the wal is located at current node.
- Otherwise fallback the old logic.

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the enhance_enable_querynode_in_streamingnode branch from 8b9bc00 to 1e80731 Compare January 2, 2025 03:56
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: chyezh <[email protected]>
Copy link
Contributor

mergify bot commented Jan 2, 2025

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants