Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bm25 import segment without bm25 stats meta #38855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: bm25 import segment without bm25 stats meta #38855

wants to merge 1 commit into from
+12 −8

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 30, 2024

relate: #38854

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aoiasd
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 30, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.54%. Comparing base (907fc24) to head (580ab2d).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38855   +/-   ##
=======================================
  Coverage   69.54%   69.54%           
=======================================
  Files         296      296           
  Lines       26535    26536    +1     
=======================================
+ Hits        18454    18455    +1     
  Misses       8081     8081
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.54% <ø> (+<0.01%) ⬆️
Go ∅ <ø> (∅)

see 1 file with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@aoiasd Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. ci-passed and removed dco-passed DCO check passed. labels Dec 30, 2024
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. ci-passed labels Dec 31, 2024
@aoiasd aoiasd mentioned this pull request Dec 31, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot pushed a commit that referenced this pull request Dec 31, 2024
@aoiasd
fix:[Cherry-pick] bm25 import segment loss stats (#38881)
6fa096e 
relate: #38854
pr: #38855

Signed-off-by: aoiasd <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@bigsheeper bigsheeper bigsheeper left review comments

@chyezh chyezh Awaiting requested review from chyezh

@congqixia congqixia Awaiting requested review from congqixia

Assignees
No one assigned
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aoiasd @sre-ci-robot @bigsheeper @xiaofan-luan