Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Querycoord will trigger unexpected balance task after restart #38714

Merged

Conversation

weiliu1031
Copy link
Contributor

issue: #38606
pr: #38630

@sre-ci-robot sre-ci-robot added area/internal-api size/S Denotes a PR that changes 10-29 lines. labels Dec 24, 2024
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby December 24, 2024 10:52
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 24, 2024
@weiliu1031 weiliu1031 changed the title fix: Querycoord will trigger unexpected balance task after restart fix: [2.4]Querycoord will trigger unexpected balance task after restart Dec 24, 2024
@weiliu1031 weiliu1031 changed the title fix: [2.4]Querycoord will trigger unexpected balance task after restart fix: [2.4] Querycoord will trigger unexpected balance task after restart Dec 24, 2024
@mergify mergify bot added the ci-passed label Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.52%. Comparing base (648078e) to head (12eb029).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/target.go 66.66% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38714      +/-   ##
==========================================
- Coverage   83.40%   79.52%   -3.89%     
==========================================
  Files         809     1077     +268     
  Lines      143068   169590   +26522     
==========================================
+ Hits       119333   134859   +15526     
- Misses      19243    30242   +10999     
+ Partials     4492     4489       -3     
Files with missing lines Coverage Δ
internal/querycoordv2/checkers/balance_checker.go 96.26% <100.00%> (+0.30%) ⬆️
internal/querycoordv2/meta/target_manager.go 91.54% <100.00%> (+1.35%) ⬆️
internal/querycoordv2/meta/target.go 89.74% <66.66%> (-4.60%) ⬇️

... and 300 files with indirect coverage changes

@weiliu1031 weiliu1031 force-pushed the fix_balance_after_qc_restarts24 branch from 5241ae8 to 3cd369d Compare December 24, 2024 13:34
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 24, 2024
@mergify mergify bot removed the ci-passed label Dec 24, 2024
Copy link
Contributor

@tedxu tedxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

return !b.targetMgr.IsCurrentTargetReady(cid)
})
if len(notReadyCollections) > 0 {
log.RatedInfo(10, "skip normal balance, cause collection not ready for balance", zap.Int64s("collectionIDs", notReadyCollections))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to log all collections here.

@weiliu1031 weiliu1031 force-pushed the fix_balance_after_qc_restarts24 branch from 3cd369d to 12eb029 Compare December 24, 2024 14:04
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 24, 2024
@chyezh
Copy link
Contributor

chyezh commented Dec 24, 2024

/lgtm

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: weiliu1031, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8fe883f into milvus-io:2.4 Dec 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants