-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix privilege group list and list collections #38684
Conversation
@shaoting-huang go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38684 +/- ##
===========================================
+ Coverage 69.33% 81.08% +11.74%
===========================================
Files 292 1381 +1089
Lines 26187 195243 +169056
===========================================
+ Hits 18158 158310 +140152
- Misses 8029 31343 +23314
- Partials 0 5590 +5590
|
after fix:
|
c3aa6a5
to
398f1b4
Compare
@shaoting-huang E2e jenkins job failed, comment |
398f1b4
to
9acc4b4
Compare
@shaoting-huang E2e jenkins job failed, comment |
@shaoting-huang go-sdk check failed, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
return lo.Keys(builtinPrivilegeGroups) | ||
} | ||
|
||
func (p *rbacConfig) IsCollectionPrivilegeGroup(privName string) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: it is unusual to write implementation details in configuration declarations.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
9acc4b4
to
b50cc25
Compare
@shaoting-huang go-sdk check failed, comment |
Signed-off-by: shaoting-huang <[email protected]>
b50cc25
to
02ca794
Compare
cherry-pick from: #38684 related: #37031 Signed-off-by: shaoting-huang <[email protected]>
@shaoting-huang E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
cherry-pick from: #38684 related: #37031 Signed-off-by: shaoting-huang <[email protected]>
related: #37031