Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Decode unicode for json key in expression #38652

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #38626

master pr: #38651

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 23, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 23, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 23, 2024
@sre-ci-robot sre-ci-robot merged commit ad68bc6 into milvus-io:2.4 Dec 23, 2024
13 checks passed
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.16%. Comparing base (e82af48) to head (f364ae8).
Report is 3 commits behind head on 2.4.

❗ There is a different number of reports uploaded between BASE (e82af48) and HEAD (f364ae8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e82af48) HEAD (f364ae8)
2 1
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38652      +/-   ##
==========================================
- Coverage   80.44%   72.16%   -8.29%     
==========================================
  Files        1077     1077              
  Lines      169442   169450       +8     
==========================================
- Hits       136316   122278   -14038     
- Misses      28677    42701   +14024     
- Partials     4449     4471      +22     
Files with missing lines Coverage Δ
internal/parser/planparserv2/parser_visitor.go 86.05% <100.00%> (+0.02%) ⬆️
internal/parser/planparserv2/plan_parser_v2.go 86.70% <ø> (-1.57%) ⬇️
internal/parser/planparserv2/utils.go 87.10% <100.00%> (+0.65%) ⬆️

... and 232 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants