Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix panic caused by removing directory #38622

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Fix panic caused by removing directory #38622

wants to merge 3 commits into from
+24 −9

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 20, 2024 •
edited
Loading

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@liliu-z
Copy link
Member

liliu-z commented Dec 20, 2024

/approve
/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sre-ci-robot sre-ci-robot removed the lgtm label Dec 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Dec 20, 2024

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby sunby force-pushed the fix_remove_dir_panic branch from 4b963f9 to ea254a0 Compare December 23, 2024 06:59
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.11%. Comparing base (907fc24) to head (46f238c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/storage/LocalChunkManager.cpp 0.00% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38622       +/-   ##
===========================================
+ Coverage   69.54%   81.11%   +11.57%     
===========================================
  Files         296     1387     +1091     
  Lines       26535   196227   +169692     
===========================================
+ Hits        18454   159178   +140724     
- Misses       8081    31455    +23374     
- Partials        0     5594     +5594
Components Coverage Δ
Client 79.12% <ø> (∅)
Core 69.53% <28.57%> (-0.02%) ⬇️
Go 83.08% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.cpp 92.72% <100.00%> (+0.05%) ⬆️
internal/core/src/storage/LocalChunkManager.cpp 66.00% <0.00%> (-2.75%) ⬇️

... and 1091 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 23, 2024
@sunby sunby force-pushed the fix_remove_dir_panic branch from ea254a0 to f590238 Compare December 23, 2024 09:38
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 23, 2024
@mergify mergify bot removed the ci-passed label Dec 23, 2024
@sunby sunby force-pushed the fix_remove_dir_panic branch from f590238 to f975678 Compare December 23, 2024 12:21
@mergify mergify bot added the ci-passed label Dec 23, 2024
@sunby sunby force-pushed the fix_remove_dir_panic branch from f975678 to bc8fc34 Compare December 26, 2024 08:35
@sre-ci-robot sre-ci-robot removed the lgtm label Dec 26, 2024
@mergify mergify bot removed the ci-passed label Dec 26, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Dec 30, 2024

rerun cpp-unit-test

@sunby sunby force-pushed the fix_remove_dir_panic branch from bc8fc34 to 3633d18 Compare December 30, 2024 12:47
@liliu-z
Copy link
Member

liliu-z commented Dec 30, 2024

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 30, 2024
@sunby
Copy link
Contributor Author

sunby commented Dec 31, 2024

rerun cpp-unit-test

@mergify mergify bot added ci-passed and removed ci-passed labels Dec 31, 2024
@sunby sunby force-pushed the fix_remove_dir_panic branch from 3633d18 to 46f238c Compare January 2, 2025 06:18
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Jan 2, 2025
@mergify mergify bot removed the ci-passed label Jan 2, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Jan 2, 2025

/run-cpu-e2e

@sunby
Copy link
Contributor Author

sunby commented Jan 2, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Jan 2, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@xiaofan-luan xiaofan-luan

@liliu-z liliu-z

Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sunby @liliu-z @xiaofan-luan @sre-ci-robot