Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] rbac revoke check if there is same privilege in other privilege groups granted #38559

Merged
merged 1 commit into from
Dec 18, 2024

rbac revoke check with meta

5290f3e
Select commit
Loading
Failed to load commit list.
Merged

fix: [2.4] rbac revoke check if there is same privilege in other privilege groups granted #38559

rbac revoke check with meta
5290f3e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 18, 2024 in 0s

72.18% (target 77.00%)

View this Pull Request on Codecov

72.18% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 72.18%. Comparing base (b469999) to head (5290f3e).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 62.50% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38559      +/-   ##
==========================================
+ Coverage   70.35%   72.18%   +1.82%     
==========================================
  Files        1077     1077              
  Lines      169394   169410      +16     
==========================================
+ Hits       119184   122281    +3097     
+ Misses      45745    42665    -3080     
+ Partials     4465     4464       -1
Files with missing lines Coverage Δ
internal/rootcoord/root_coord.go 87.71% <62.50%> (-0.15%) ⬇️

... and 135 files with indirect coverage changes

View more details on Codecov