Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4]alterdatabase support delete property #38450

Merged
merged 6 commits into from
Dec 15, 2024

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 13, 2024

alterdatabase support delete property
issue: #38379

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file area/test sig/testing size/L Denotes a PR that changes 100-499 lines. labels Dec 13, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 13, 2024
Copy link
Contributor

mergify bot commented Dec 13, 2024

@JsDove Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Dec 13, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 13, 2024

/approve
/lgtm

Signed-off-by: Xianhui.Lin <[email protected]>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 32.43243% with 25 lines in your changes missing coverage. Please review.

Project coverage is 83.38%. Comparing base (1da4ac4) to head (f98e44a).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/task.go 0.00% 19 Missing ⚠️
internal/rootcoord/alter_database_task.go 64.70% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38450      +/-   ##
==========================================
+ Coverage   79.50%   83.38%   +3.87%     
==========================================
  Files        1077      809     -268     
  Lines      169330   142877   -26453     
==========================================
- Hits       134633   119134   -15499     
+ Misses      30234    19274   -10960     
- Partials     4463     4469       +6     
Files with missing lines Coverage Δ
internal/proxy/task_database.go 97.96% <100.00%> (+0.01%) ⬆️
internal/rootcoord/alter_collection_task.go 50.82% <ø> (-0.28%) ⬇️
internal/rootcoord/alter_database_task.go 80.85% <64.70%> (-6.51%) ⬇️
internal/proxy/task.go 81.64% <0.00%> (-0.96%) ⬇️

... and 301 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 13, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 352e51a into milvus-io:2.4 Dec 15, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants