Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] add privilege group privilege into built-in privilege group #38408

Merged

Conversation

shaoting-huang
Copy link
Contributor

@shaoting-huang shaoting-huang commented Dec 12, 2024

cherry-pick from master: #38393
related issue: #37031

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 12, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 12, 2024
Copy link
Contributor

mergify bot commented Dec 12, 2024

@shaoting-huang Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.31%. Comparing base (cacac66) to head (59c9299).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
pkg/util/constant.go 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38408      +/-   ##
==========================================
- Coverage   72.13%   70.31%   -1.83%     
==========================================
  Files        1077     1077              
  Lines      169022   169024       +2     
==========================================
- Hits       121931   118842    -3089     
- Misses      42632    45717    +3085     
- Partials     4459     4465       +6     
Files with missing lines Coverage Δ
pkg/util/constant.go 96.82% <83.33%> (-1.54%) ⬇️

... and 121 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 19818c5 into milvus-io:2.4 Dec 12, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants