Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: use lazy initializing client for streaming node #38400

Merged
merged 2 commits into from
Dec 23, 2024
Merged

enhance: use lazy initializing client for streaming node #38400

merged 2 commits into from
Dec 23, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 12, 2024

issue: #38399

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 12, 2024
@chyezh chyezh mentioned this pull request Dec 12, 2024
Open
8 tasks
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.19718% with 48 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (2afe2ea) to head (d9ed5b9).
Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
internal/distributed/streamingnode/service.go 60.00% 12 Missing and 6 partials ⚠️
...ingnode/server/flusher/flusherimpl/flusher_impl.go 75.00% 8 Missing and 4 partials ⚠️
...ode/server/flusher/flusherimpl/channel_lifetime.go 45.45% 4 Missing and 2 partials ⚠️
...ingnode/server/resource/idalloc/basic_allocator.go 50.00% 4 Missing and 2 partials ⚠️
.../interceptors/segment/manager/partition_manager.go 40.00% 2 Missing and 1 partial ⚠️
...l/interceptors/segment/manager/pchannel_manager.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38400      +/-   ##
==========================================
- Coverage   80.91%   80.91%   -0.01%     
==========================================
  Files        1375     1374       -1     
  Lines      193645   193696      +51     
==========================================
+ Hits       156692   156723      +31     
- Misses      31418    31432      +14     
- Partials     5535     5541       +6
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.97% <ø> (ø)
Go 83.00% <66.19%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/streamingnode/server/builder.go 100.00% <100.00%> (ø)
...streamingnode/server/resource/idalloc/allocator.go 100.00% <100.00%> (ø)
internal/streamingnode/server/resource/resource.go 88.40% <100.00%> (ø)
...rnal/streamingnode/server/resource/test_utility.go 100.00% <100.00%> (ø)
pkg/util/retry/options.go 100.00% <100.00%> (ø)
pkg/util/retry/retry.go 89.65% <100.00%> (ø)
.../interceptors/segment/manager/partition_manager.go 83.11% <40.00%> (-1.06%) ⬇️
...l/interceptors/segment/manager/pchannel_manager.go 65.65% <40.00%> (-0.84%) ⬇️
...ode/server/flusher/flusherimpl/channel_lifetime.go 68.08% <45.45%> (-4.01%) ⬇️
...ingnode/server/resource/idalloc/basic_allocator.go 83.72% <50.00%> (-6.28%) ⬇️
... and 2 more

... and 28 files with indirect coverage changes

bigsheeper
bigsheeper reviewed Dec 13, 2024
View reviewed changes
internal/streamingnode/server/flusher/flusherimpl/flusher_impl.go Outdated
broker := broker.NewCoordBroker(dc, paramtable.GetNodeID())
cpUpdater := util.NewChannelCheckpointUpdater(broker)
go cpUpdater.Start()
// When the flusher exits, the cpUpdater should be closed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this result in being unable to update the checkpoint when the flowgraphs are closing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

bigsheeper
bigsheeper reviewed Dec 13, 2024
View reviewed changes
internal/distributed/streamingnode/service.go Outdated
log.Info("StreamingNode wait for DataCoord ready")
s.dataCoord.Set(dataCoord)
return nil
})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retry.AttemptAlways() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

bigsheeper
bigsheeper reviewed Dec 13, 2024
View reviewed changes
internal/distributed/streamingnode/service.go
log.Info("StreamingNode wait for RootCoord done")
s.rootCoord.Set(rootCoord)
return nil
}, retry.AttemptAlways())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we throw an error after the context ends instead of retrying indefinitely?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retry will stop when error is context timeout or canceled

@chyezh chyezh force-pushed the enhance_use_lazy_client_for_streamingnode branch from a321eb1 to e59e3d9 Compare December 13, 2024 06:19
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024

@chyezh cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 13, 2024
@bigsheeper
Copy link
Contributor

/lgtm

@chyezh chyezh force-pushed the enhance_use_lazy_client_for_streamingnode branch from e59e3d9 to 0dc6628 Compare December 16, 2024 02:41
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Dec 16, 2024
@mergify mergify bot removed the ci-passed label Dec 16, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 16, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 16, 2024
@chyezh chyezh force-pushed the enhance_use_lazy_client_for_streamingnode branch from 0dc6628 to d9ed5b9 Compare December 17, 2024 01:26
@mergify mergify bot removed the ci-passed label Dec 17, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 17, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 17, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 17, 2024
@chyezh chyezh added this to the 2.6.0 milestone Dec 17, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chyezh
Copy link
Contributor Author

chyezh commented Dec 23, 2024

/lgtm

@sre-ci-robot
Copy link
Contributor

@chyezh: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chyezh chyezh added the lgtm label Dec 23, 2024
@sre-ci-robot sre-ci-robot merged commit 984a605 into milvus-io:master Dec 23, 2024
18 of 20 checks passed
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this pull request Dec 26, 2024
@chyezh @NicoYuan1986
enhance: use lazy initializing client for streaming node (milvus-io#3…
3f3801b 
…8400)

issue: milvus-io#38399

---------

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper bigsheeper left review comments

@godchen0212 godchen0212 Awaiting requested review from godchen0212

@sunby sunby Awaiting requested review from sunby

Assignees

@bigsheeper bigsheeper

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chyezh @bigsheeper @sre-ci-robot @jaime0815