Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Set the start time for index tasks that no need actual building #38353

Merged

Conversation

xiaocai2333
Copy link
Contributor

@xiaocai2333 xiaocai2333 commented Dec 10, 2024

issue: #38354

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 10, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 10, 2024
Copy link
Contributor

mergify bot commented Dec 10, 2024

@xiaocai2333 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Dec 10, 2024
Copy link
Contributor

mergify bot commented Dec 10, 2024

@xiaocai2333 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.31%. Comparing base (c4b6460) to head (e998b26).
Report is 8 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38353       +/-   ##
===========================================
- Coverage   80.41%   70.31%   -10.10%     
===========================================
  Files        1074     1074               
  Lines      168774   168775        +1     
===========================================
- Hits       135713   118672    -17041     
- Misses      28613    45656    +17043     
+ Partials     4448     4447        -1     
Files with missing lines Coverage Δ
internal/datacoord/task_index.go 84.67% <100.00%> (+0.05%) ⬆️

... and 274 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Dec 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e758d8e into milvus-io:2.4 Dec 11, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4-features approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants