Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Reduce GetRecoveryInfo calls #37863

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Merge branch 'master' of https://github.com/milvus-io/milvus into 241…

fb6db4b
Select commit
Loading
Failed to load commit list.
Open

enhance: Reduce GetRecoveryInfo calls #37863

Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
fb6db4b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 1, 2025 in 1s

80.58% (target 77.00%)

View this Pull Request on Codecov

80.58% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 86.36364% with 39 lines in your changes missing coverage. Please review.

Project coverage is 80.58%. Comparing base (accfacf) to head (fb6db4b).

Files with missing lines Patch % Lines
internal/datacoord/services.go 81.70% 11 Missing and 4 partials ⚠️
internal/querycoordv2/observers/target_observer.go 75.00% 8 Missing and 2 partials ⚠️
internal/datacoord/dataview/view_manager.go 93.13% 6 Missing and 1 partial ⚠️
internal/querycoordv2/meta/coordinator_broker.go 76.47% 3 Missing and 1 partial ⚠️
internal/datacoord/handler.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37863      +/-   ##
==========================================
- Coverage   81.13%   80.58%   -0.55%     
==========================================
  Files        1385     1085     -300     
  Lines      196070   168659   -27411     
==========================================
- Hits       159083   135918   -23165     
+ Misses      31397    27168    -4229     
+ Partials     5590     5573      -17     
Components Coverage Δ
Client 79.12% <ø> (ø)
Core ∅ <ø> (∅)
Go 80.63% <86.36%> (-2.47%) ⬇️
Files with missing lines Coverage Δ
internal/datacoord/dataview/update_chan.go 100.00% <100.00%> (ø)
internal/datacoord/server.go 68.53% <100.00%> (-4.70%) ⬇️
internal/distributed/datacoord/client/client.go 92.57% <100.00%> (-3.64%) ⬇️
internal/distributed/datacoord/service.go 86.23% <100.00%> (-3.19%) ⬇️
pkg/util/paramtable/component_param.go 98.39% <100.00%> (+<0.01%) ⬆️
pkg/util/typeutil/map.go 100.00% <100.00%> (+8.75%) ⬆️
internal/datacoord/handler.go 77.86% <0.00%> (-1.89%) ⬇️
internal/querycoordv2/meta/coordinator_broker.go 86.73% <76.47%> (-4.71%) ⬇️
internal/datacoord/dataview/view_manager.go 93.13% <93.13%> (ø)
internal/querycoordv2/observers/target_observer.go 82.38% <75.00%> (-7.71%) ⬇️
... and 1 more

... and 542 files with indirect coverage changes