Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Generate milvusclient mockery with latest proto #37567

Conversation

congqixia
Copy link
Contributor

Related to #37558

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. approved area/compilation labels Nov 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 11, 2024
@congqixia congqixia changed the title enhance: Generate milvusclient mockery with lastest proto enhance: Generate milvusclient mockery with latest proto Nov 11, 2024
Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 11, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (a88fff1) to head (78357a6).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37567       +/-   ##
===========================================
+ Coverage   68.13%   80.57%   +12.44%     
===========================================
  Files         290     1356     +1066     
  Lines       25395   190009   +164614     
===========================================
+ Hits        17302   153105   +135803     
- Misses       8093    31495    +23402     
- Partials        0     5409     +5409     
Components Coverage Δ
Client 60.27% <ø> (∅)
Core 68.13% <ø> (ø)
Go 83.22% <ø> (∅)

see 1066 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 11, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit 83d2729 into milvus-io:master Nov 11, 2024
20 checks passed
@congqixia congqixia deleted the enhance/generate_milvusclient_mockery_utd branch November 11, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/dependency Pull requests that update a dependency file area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants