Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Support custom privilege group for RBAC #37087

Merged
merged 7 commits into from
Nov 9, 2024
Merged

enhance: Support custom privilege group for RBAC #37087

merged 7 commits into from
Nov 9, 2024

Conversation

shaoting-huang
Copy link
Contributor

issue: #37031

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. area/dependency Pull requests that update a dependency file labels Oct 23, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@shaoting-huang

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly

Please review and update your PR to comply with these guidelines.

@shaoting-huang shaoting-huang changed the title Support custom privilege group for RBAC enhance: Support custom privilege group for RBAC Oct 23, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Oct 23, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@shaoting-huang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@shaoting-huang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 23, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Oct 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@shaoting-huang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

weiliu1031
weiliu1031 reviewed Oct 24, 2024
View reviewed changes
internal/distributed/proxy/httpserver/constant.go Outdated Show resolved Hide resolved
internal/distributed/proxy/httpserver/request_v2.go Show resolved Hide resolved
internal/proxy/util.go Outdated Show resolved Hide resolved
internal/rootcoord/meta_table.go Outdated Show resolved Hide resolved
internal/rootcoord/meta_table.go Outdated Show resolved Hide resolved
internal/rootcoord/meta_table.go Outdated Show resolved Hide resolved
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@shaoting-huang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 24, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 25, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@shaoting-huang
rebase proto
85a5083 
Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Nov 8, 2024
@shaoting-huang
fix ut
4cb79b4 
Signed-off-by: shaoting-huang <[email protected]>
@shaoting-huang
fix ut
3b2b820 
Signed-off-by: shaoting-huang <[email protected]>
@weiliu1031
Copy link
Contributor

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
rebase proto
c0162ac 
Signed-off-by: shaoting-huang <[email protected]>
@sre-ci-robot sre-ci-robot removed the lgtm label Nov 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@shaoting-huang cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
rebase proto
d636d5a 
Signed-off-by: shaoting-huang <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 8, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@shaoting-huang
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 8, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shaoting-huang, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 70605cf into milvus-io:master Nov 9, 2024
18 of 20 checks passed
@shaoting-huang shaoting-huang mentioned this pull request Nov 9, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Nov 11, 2024
@shaoting-huang
enhance: [2.4] RBAC custom privilege group (#37560)
9e8b6ac 
Cherry-pick from master
pr: #37087,
#37558
issue: #37031

---------

Signed-off-by: shaoting-huang <[email protected]>
@shaoting-huang shaoting-huang mentioned this pull request Dec 10, 2024
Open
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiliu1031 weiliu1031 weiliu1031 left review comments

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@xiaofan-luan xiaofan-luan

@weiliu1031 weiliu1031

Labels
approved area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaoting-huang @weiliu1031 @xiaofan-luan @sre-ci-robot