Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support importing files from local storage #36696

Closed

Conversation

bigsheeper
Copy link
Contributor

Support importing files from local storage and tidy import options.

issue: #36445

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 8, 2024
Copy link
Contributor

mergify bot commented Oct 8, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 8, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 82.32%. Comparing base (ef1832f) to head (93becaf).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
internal/util/importutilv2/option.go 83.33% 3 Missing ⚠️
internal/util/importutilv2/reader.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #36696       +/-   ##
===========================================
+ Coverage   71.57%   82.32%   +10.75%     
===========================================
  Files        1286     1286               
  Lines      152045   152059       +14     
===========================================
+ Hits       108825   125189    +16364     
+ Misses      38160    21813    -16347     
+ Partials     5060     5057        -3     
Files with missing lines Coverage Δ
internal/datacoord/services.go 86.12% <100.00%> (+0.10%) ⬆️
internal/proxy/impl.go 85.88% <100.00%> (+<0.01%) ⬆️
internal/util/importutilv2/reader.go 60.71% <0.00%> (-4.68%) ⬇️
internal/util/importutilv2/option.go 71.01% <83.33%> (+3.08%) ⬆️

... and 277 files with indirect coverage changes

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 9, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Oct 9, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

It is not a mature solution, so close this PR.

@bigsheeper bigsheeper closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants