Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: upgrade proto to use partition related privileges #29100

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Dec 11, 2023

issue: milvus-proto #212
master pr: #28961

milvus can't use partition related privileges until upgrade milvus-proto, even if them were added to milvus-proto

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Dec 11, 2023
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Dec 11, 2023
Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi PowderLi changed the title upgrade proto to use partition related privileges enhance: upgrade proto to use partition related privileges Dec 11, 2023
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue and removed do-not-merge/invalid-pr-format labels Dec 11, 2023
Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 11, 2023
Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@czs007 czs007 added kind/improvement Changes related to something improve, likes ut and code refactor kind/branch-feature labels Dec 11, 2023
Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #29100 (b1e5a25) into 2.3 (0b532b4) will increase coverage by 0.01%.
Report is 2 commits behind head on 2.3.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29100      +/-   ##
==========================================
+ Coverage   82.02%   82.04%   +0.01%     
==========================================
  Files         832      823       -9     
  Lines      119180   119147      -33     
==========================================
- Hits        97758    97749       -9     
+ Misses      18191    18171      -20     
+ Partials     3231     3227       -4     
Files Coverage Δ
pkg/util/constant.go 79.31% <ø> (ø)
internal/distributed/proxy/service.go 79.97% <0.00%> (+0.02%) ⬆️
internal/proxy/impl.go 85.69% <0.00%> (-0.12%) ⬇️

... and 161 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 11, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 12, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Dec 12, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 92db415 into milvus-io:2.3 Dec 12, 2023
13 of 14 checks passed
@PowderLi PowderLi deleted the 2.3-upgrade-proto branch January 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/branch-feature kind/enhancement Issues or changes related to enhancement kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants