[Bug]: Query filter with JSON: "AND" not working, must be "&&" (documentation issue?)

[chbussler]

Is there an existing issue for this?

• I have searched the existing issues

Environment

- Milvus version: 2.5.1
- Deployment mode(standalone or cluster): standalone
- MQ type(rocksmq, pulsar or kafka): n/a
- SDK version(e.g. pymilvus v2.0.0rc2): pymilvus-2.5.0
- OS(Ubuntu or CentOS): Docker
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Milvus raises exception:

raise MilvusException(status.code, status.reason, status.error_code)
pymilvus.exceptions.MilvusException: <MilvusException: (code=1100, message=failed to create delete plan: cannot parse expression: storage_object_id["storage_bucket_name"] == "drag-b-10" AND storage_object_id["storage_bucket_time_created"] == "2024-12-24 04:27:00.016000" AND storage_object_id["name"] == "t1.txt" AND storage_object_id["generation"] == "1735487491829867" , error: invalid expression: storage_object_id["storage_bucket_name"] == "drag-b-10" AND storage_object_id["storage_bucket_time_created"] == "2024-12-24 04:27:00.016000" AND storage_object_id["name"] == "t1.txt" AND storage_object_id["generation"] == "1735487491829867" : invalid parameter)>

Expected Behavior

Milvus does not raise exception when AND is replaced by &&:

storage_object_id["storage_bucket_name"] == "drag-b-10" && storage_object_id["storage_bucket_time_created"] == "2024-12-24 04:27:00.016000" && storage_object_id["name"] == "t1.txt" && storage_object_id["generation"] == "1735568888486502"

The documentation says to use AND, the code says to use &&: https://milvus.io/docs/use-json-fields.md

The expected behavior is

1. both, code and documentation, are consistent
2. when a parse error exception is raised, the text displayed not only states that there was a parse exception, but what it was. For each user-visible error: state what it was, explain it, state how to fix it

Steps To Reproduce

You can manually reproduce this 

- with Attu by constructing the filter using the filter construction dialog and see that it uses "&&". 
- When you replace "&&" with "AND", there is an exception raised in a user dialog.

Milvus Log

No response

Anything else?

No response

[xiaofan-luan]

/assign @xiaocai2333

[xiaocai2333]

Milvus's expression parsing is case-sensitive. Currently, we have only defined and in the g4 file. Please try using and.

milvus/internal/parser/planparserv2/Plan.g4

Lines 74 to 75 in 7fe2cd0

	AND: '&&' | 'and';
	OR: '||' | 'or';

[xiaocai2333]

/assign @chbussler

[xiaofan-luan]

/assign @chbussler

LOL, I didn't know this etier

[chbussler]

Still, the documentation isn't matching the code then: https://milvus.io/docs/boolean.md

• Documentation says AND, not and
• Documentation does not state that && is a valid operator as well

And there are other terminals like LIKE, IN, OR (see your code extract above), NOT that have a similar issue as AND.

As a side note, Attu uses && as operator when generating the expression from the expression builder.

[xiaofan-luan]

//milvus.io/docs/boolean.md

Agree, thanks for the feedback.

we will fix the document as soon as possible

[xiaofan-luan]

actaully let's fix the compiler as well.
At least for IN we support both in and IN

[xiaofan-luan]

docuement request and pr is submitted