Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix rootcoord meta mutex contention #38799

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: Fix rootcoord meta mutex contention #38799

wants to merge 8 commits into from
+155 −6

Conversation

bigsheeper
Copy link
Contributor

RootCoord meta uses copy-on-write, allowing the removal of unnecessary copies.

issue: #37630

@sre-ci-robot sre-ci-robot requested review from czs007 and yhmo December 26, 2024 16:49
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 26, 2024
@bigsheeper
Copy link
Contributor Author

image
image

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 26, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (accfacf) to head (577fd66).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38799      +/-   ##
==========================================
+ Coverage   81.13%   82.93%   +1.79%     
==========================================
  Files        1385     1091     -294     
  Lines      196070   169663   -26407     
==========================================
- Hits       159083   140707   -18376     
+ Misses      31397    23355    -8042     
- Partials     5590     5601      +11
Components Coverage Δ
Client 79.12% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.08% <100.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/metastore/model/collection.go 84.10% <100.00%> (+2.85%) ⬆️
internal/rootcoord/meta_table.go 83.30% <100.00%> (ø)

... and 317 files with indirect coverage changes

@bigsheeper bigsheeper mentioned this pull request Dec 27, 2024
Merged
czs007 pushed a commit that referenced this pull request Dec 27, 2024
@bigsheeper
fix: [10kcp] Fix rootcoord meta mutex contention (#38803)
4d0594b 
RootCoord meta uses copy-on-write, allowing the removal of unnecessary
copies.

issue: #37630

pr: #38799

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper bigsheeper mentioned this pull request Dec 27, 2024
Open
39 tasks
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Dec 30, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
update
ff951fb 
Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

This was referenced Jan 1, 2025
Open
Open
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@yhmo yhmo Awaiting requested review from yhmo

Assignees
No one assigned
Labels
10kcp PR related to 10k collection partitions Project dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigsheeper @sre-ci-robot