Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix consume blocked due to too many consumers #38455

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

This PR limits the maximum number of consumers per pchannel to 10 for each QueryNode and DataNode.

issue: #37630

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 13, 2024
czs007 pushed a commit that referenced this pull request Dec 13, 2024
This PR limits the maximum number of consumers per pchannel to 10 for
each QueryNode and DataNode.

issue: #37630

pr: #38455

---------

Signed-off-by: SimFG <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Co-authored-by: SimFG <[email protected]>
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.93%. Comparing base (95c1ccc) to head (fa64b46).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...hcommon/pipeline/flow_graph_dmstream_input_node.go 85.71% 4 Missing and 1 partial ⚠️
pkg/mq/msgdispatcher/client.go 62.50% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38455       +/-   ##
===========================================
+ Coverage   69.45%   82.93%   +13.48%     
===========================================
  Files         294     1091      +797     
  Lines       26430   169670   +143240     
===========================================
+ Hits        18357   140717   +122360     
- Misses       8073    23358    +15285     
- Partials        0     5595     +5595     
Components Coverage Δ
Client 79.12% <ø> (∅)
Core ∅ <ø> (∅)
Go 83.08% <90.47%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/channel_manager.go 87.61% <100.00%> (ø)
internal/util/pipeline/stream_pipeline.go 93.57% <100.00%> (ø)
pkg/util/paramtable/component_param.go 98.38% <ø> (ø)
pkg/util/paramtable/service_param.go 99.16% <100.00%> (ø)
pkg/mq/msgdispatcher/client.go 95.58% <62.50%> (ø)
...hcommon/pipeline/flow_graph_dmstream_input_node.go 89.04% <85.71%> (ø)

... and 1379 files with indirect coverage changes

Signed-off-by: bigsheeper <[email protected]>
Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Dec 17, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 17, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 17, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 30, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 31, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 1, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants