Skip to content

Commit

Permalink
improve statschecker unittest
Browse files Browse the repository at this point in the history
Signed-off-by: Xianhui.Lin <[email protected]>
  • Loading branch information
JsDove committed Dec 13, 2024
1 parent bc70b94 commit 2910f86
Show file tree
Hide file tree
Showing 10 changed files with 313 additions and 393 deletions.
11 changes: 11 additions & 0 deletions internal/core/src/common/jsmn.h
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
// Copyright (C) 2019-2020 Zilliz. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software distributed under the License
// is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
// or implied. See the License for the specific language governing permissions and limitations under the License

/*
* MIT License
*
Expand Down
2 changes: 1 addition & 1 deletion internal/core/src/exec/expression/UnaryExpr.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -483,7 +483,7 @@ PhyUnaryRangeFilterExpr::ExecArrayEqualForIndex(bool reverse) {
};
} else {
auto size_per_chunk = segment_->size_per_chunk();
retrieve = [size_per_chunk, this](int64_t offset) -> auto {
retrieve = [ size_per_chunk, this ](int64_t offset) -> auto {
auto chunk_idx = offset / size_per_chunk;
auto chunk_offset = offset % size_per_chunk;
const auto& chunk =
Expand Down
2 changes: 1 addition & 1 deletion internal/core/src/exec/expression/UnaryExpr.h
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ class PhyUnaryRangeFilterExpr : public SegmentExpr {
template <typename ExprValueType>
VectorPtr
ExecRangeVisitorImplJsonForIndex();

template <typename ExprValueType>
VectorPtr
ExecRangeVisitorImplArray(OffsetVector* input = nullptr);
Expand Down
2 changes: 1 addition & 1 deletion internal/core/src/index/JsonKeyInvertedIndex.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class JsonKeyInvertedIndex : public InvertedIndexTantivy<std::string> {
explicit JsonKeyInvertedIndex(const storage::FileManagerContext& ctx,
bool is_load);

~JsonKeyInvertedIndex() override {};
~JsonKeyInvertedIndex() override{};

public:
BinarySet
Expand Down
4 changes: 2 additions & 2 deletions internal/core/src/indexbuilder/index_c.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -282,8 +282,8 @@ BuildJsonKeyIndex(CBinarySet* c_binary_set,

auto field_schema =
FieldMeta::ParseFrom(build_index_info->field_schema());
auto index =
std::make_unique<index::JsonKeyInvertedIndex>(fileManagerContext, false);
auto index = std::make_unique<index::JsonKeyInvertedIndex>(
fileManagerContext, false);
index->Build(config);
auto binary =
std::make_unique<knowhere::BinarySet>(index->Upload(config));
Expand Down
2 changes: 1 addition & 1 deletion internal/core/src/mmap/ChunkedColumn.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class ChunkedColumnBase : public ColumnBase {
}
}

virtual ~ChunkedColumnBase() {};
virtual ~ChunkedColumnBase(){};

virtual void
AppendBatch(const FieldDataPtr data) override {
Expand Down
Loading

0 comments on commit 2910f86

Please sign in to comment.