Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: RBAC Custom Privilege Group API #845

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

shaoting-huang
Copy link
Contributor

@sre-ci-robot
Copy link

Welcome @shaoting-huang! It looks like this is your first PR to milvus-io/milvus-sdk-go 🎉

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 13, 2024
@shaoting-huang shaoting-huang changed the title enhance: [2.4] RBAC Custom Privilege group enhance: RBAC Custom Privilege group Nov 13, 2024
@shaoting-huang shaoting-huang changed the title enhance: RBAC Custom Privilege group enhance: RBAC Custom Privilege Group API Nov 13, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 13, 2024
@weiliu1031
Copy link
Contributor

/cc @congqixia

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot sre-ci-robot added approved review approved and removed lgtm look good to me labels Nov 13, 2024
Signed-off-by: shaoting-huang <[email protected]>
@mergify mergify bot added the ci-passed auto merge needed label label Nov 13, 2024
@congqixia
Copy link
Contributor

/kind enhancement

@sre-ci-robot sre-ci-robot added the kind/enhancement New feature or request label Nov 14, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Nov 14, 2024
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3d596ff into milvus-io:master Nov 14, 2024
7 checks passed
shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this pull request Nov 14, 2024
shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this pull request Nov 14, 2024
shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this pull request Nov 14, 2024
shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this pull request Nov 21, 2024
shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this pull request Nov 21, 2024
shaoting-huang added a commit to shaoting-huang/milvus-sdk-go that referenced this pull request Nov 26, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label kind/enhancement New feature or request lgtm look good to me size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants