Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Sync autoID insert/upsert test cases #788

Merged

Conversation

congqixia
Copy link
Contributor

Insert/Upsert behavior changes for milvus master branch. This PR updates some error message and error check for upsert with PKs when autoID=true.

Insert/Upsert behavior changes for milvus master branch. This PR updates
some error message and error check for upsert with PKs when autoID=true.

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot requested review from sunby and yah01 July 16, 2024 06:53
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved review approved size/XS Denotes a PR that changes 0-9 lines. labels Jul 16, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jul 16, 2024
@mergify mergify bot added ci-passed auto merge needed label test/ci intergration test labels Jul 16, 2024
@sre-ci-robot sre-ci-robot merged commit 869db52 into milvus-io:master Jul 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved review approved ci-passed auto merge needed label lgtm look good to me size/XS Denotes a PR that changes 0-9 lines. test/ci intergration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants