Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the typo error for the WithReleasePartitionMsgBase option #626

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Fix the typo error for the WithReleasePartitionMsgBase option #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions client/options_msg_base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,12 @@
}
}

// Deprecated: use WithReleaseCollectionMsgBase instead
func WithReleasePartitionMsgBase(msgBase *commonpb.MsgBase) ReleasePartitionsOption {
return WithReleasePartitionsMsgBase(msgBase)

Check warning on line 76 in client/options_msg_base.go

View check run for this annotation

Codecov / codecov/patch

client/options_msg_base.go#L76 

Added line #L76 was not covered by tests
}

func WithReleasePartitionsMsgBase(msgBase *commonpb.MsgBase) ReleasePartitionsOption {
return func(req *milvuspb.ReleasePartitionsRequest) {
req.Base = msgBase
}
Expand Down
2 changes: 1 addition & 1 deletion client/partition_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ func TestGrpcClientReleasePartitions(t *testing.T) {
})
defer mockServer.SetInjection(MHasPartition, hasPartitionInjection(t, testCollectionName, false, "testPart"))

assert.Nil(t, c.ReleasePartitions(ctx, testCollectionName, parts, WithReleasePartitionMsgBase(&commonpb.MsgBase{})))
assert.Nil(t, c.ReleasePartitions(ctx, testCollectionName, parts, WithReleasePartitionsMsgBase(&commonpb.MsgBase{})))
}

func TestGrpcShowPartitions(t *testing.T) {
Expand Down
Loading