enhance: [2.4] Set default max send recv size (#834)

Cherry pick from master pr: #832 Related to #831 --------- Signed-off-by: Congqi Xia <[email protected]>
milvus-io · Oct 22, 2024 · bc438db · bc438db
1 parent 7be975d
commit bc438db
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/client/config.go b/client/config.go
@@ -46,6 +46,10 @@ var DefaultGrpcOpts = []grpc.DialOption{
 		},
 		MinConnectTimeout: 3 * time.Second,
 	}),
+	grpc.WithDefaultCallOptions(
+		grpc.MaxCallRecvMsgSize(math.MaxInt32), // math.MaxInt32 = 2147483647, 2GB - 1
+		// not setting max send msg size, since default is Unlimited
+	),
 }
 
 // Config for milvus client.

diff --git a/test/testcases/groupby_search_test.go b/test/testcases/groupby_search_test.go
@@ -51,11 +51,9 @@ func genGroupByBinaryIndex(metricType entity.MetricType) []entity.Index {
 func genUnsupportedFloatGroupByIndex() []entity.Index {
 	idxIvfPq, _ := entity.NewIndexIvfPQ(entity.L2, 128, 16, 8)
 	idxScann, _ := entity.NewIndexSCANN(entity.L2, 16, false)
-	idxDiskAnn, _ := entity.NewIndexDISKANN(entity.L2)
 	return []entity.Index{
 		idxIvfPq,
 		idxScann,
-		idxDiskAnn,
 	}
 }
 
@@ -438,14 +436,16 @@ func TestSearchGroupByPagination(t *testing.T) {
 func TestSearchGroupByUnsupportedIndex(t *testing.T) {
 	t.Parallel()
 	for _, idx := range genUnsupportedFloatGroupByIndex() {
-		mc, ctx, collName := prepareDataForGroupBySearch(t, 3, 1000, idx, false)
-		// groupBy search
-		queryVec := common.GenSearchVectors(common.DefaultNq, common.DefaultDim, entity.FieldTypeFloatVector)
-		sp, _ := entity.NewIndexIvfFlatSearchParam(32)
-		_, err := mc.Search(ctx, collName, []string{}, "", []string{common.DefaultIntFieldName, common.DefaultVarcharFieldName},
-			queryVec, common.DefaultFloatVecFieldName, entity.MetricType(idx.Params()["metrics_type"]),
-			common.DefaultTopK, sp, client.WithGroupByField(common.DefaultVarcharFieldName))
-		common.CheckErr(t, err, false, "doesn't support search_group_by")
+		t.Run(string(idx.IndexType()), func(t *testing.T) {
+			mc, ctx, collName := prepareDataForGroupBySearch(t, 3, 1000, idx, false)
+			// groupBy search
+			queryVec := common.GenSearchVectors(common.DefaultNq, common.DefaultDim, entity.FieldTypeFloatVector)
+			sp, _ := entity.NewIndexIvfFlatSearchParam(32)
+			_, err := mc.Search(ctx, collName, []string{}, "", []string{common.DefaultIntFieldName, common.DefaultVarcharFieldName},
+				queryVec, common.DefaultFloatVecFieldName, entity.MetricType(idx.Params()["metrics_type"]),
+				common.DefaultTopK, sp, client.WithGroupByField(common.DefaultVarcharFieldName))
+			common.CheckErr(t, err, false, "doesn't support search_group_by")
+		})
 	}
 }