Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add db id in ListDatabasesResponse #346

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Nov 9, 2024

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Nov 9, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 9, 2024
@jaime0815 jaime0815 force-pushed the add-dbid-in-list-db-resp branch from d78b615 to 35cfdda Compare November 9, 2024 15:55
@mergify mergify bot added the ci-passed label Nov 9, 2024
Copy link
Collaborator

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6de3d96 into milvus-io:master Nov 11, 2024
4 checks passed
@jaime0815 jaime0815 deleted the add-dbid-in-list-db-resp branch November 11, 2024 06:29
SimFG pushed a commit to SimFG/milvus-proto that referenced this pull request Nov 29, 2024
SimFG pushed a commit to SimFG/milvus-proto that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants