partition related apis require corresponding permissions #213
Conversation
PowderLi
force-pushed
the
master-partition
branch
2 times, most recently
from
0a92295 to
8b8861f
Compare
proto/milvus.proto
Outdated
| @@ -1127,6 +1162,11 @@ message GetFlushStateResponse { | |||
| } | |||
|
|
|||
| message GetFlushAllStateRequest { | |||
| option (common.privilege_ext_obj) = { | |||
| object_type: Collection | |||
| object_privilege: PrivilegeFlush | |||
There was a problem hiding this comment.
There is a PrivilegeFlushAll privilege, which is more suitable. If do this, object_type will use Global
proto/milvus.proto
Outdated
| option (common.privilege_ext_obj) = { | ||
| object_type: Collection | ||
| object_privilege: PrivilegeFlush | ||
| object_name_indexs: 4 |
There was a problem hiding this comment.
should be object_name_index?
proto/milvus.proto
Outdated
| option (common.privilege_ext_obj) = { | ||
| object_type: Collection | ||
| object_privilege: PrivilegeFlush | ||
| object_name_indexs: -1 |
There was a problem hiding this comment.
should be object_name_index?
proto/milvus.proto
Outdated
| option (common.privilege_ext_obj) = { | ||
| object_type: Collection | ||
| object_privilege: PrivilegeFlush | ||
| object_name_indexs: 4 |
There was a problem hiding this comment.
should be object_name_index: 4
proto/milvus.proto
Outdated
| option (common.privilege_ext_obj) = { | ||
| object_type: Collection | ||
| object_privilege: PrivilegeFlush | ||
| object_name_indexs: -1 |
There was a problem hiding this comment.
should be object_name_index: -1
proto/milvus.proto
Outdated
| @@ -1127,6 +1162,11 @@ message GetFlushStateResponse { | |||
| } | |||
|
|
|||
| message GetFlushAllStateRequest { | |||
| option (common.privilege_ext_obj) = { | |||
There was a problem hiding this comment.
This time we won't expose FlushAll.
PowderLi
force-pushed
the
master-partition
branch
from
8b8861f to
4e36970
Compare
1. LoadPartition & ReleaseParititon need the existed privileges: PrivilegeLoad & PrivilegeRelease 2. CreatePartition & DropPartition & HasPartition & ShowPartitions have their own privileges 3. GetFlushState need a new privilege: PrivilegeGetFlushState Signed-off-by: PowderLi <[email protected]>
PowderLi
force-pushed
the
master-partition
branch
from
4e36970 to
f08e90b
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, PowderLi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue #212