Skip to content

Commit

Permalink
fix: use underscore for field name, "from" is keyword in python
Browse files Browse the repository at this point in the history
Signed-off-by: chyezh <[email protected]>
  • Loading branch information
chyezh committed Mar 18, 2024
1 parent 2af5058 commit 8494076
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion proto/common.proto
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ message ServerInfo {

// NodeInfo is used to describe the node information.
message NodeInfo {
int64 nodeID = 1;
int64 node_id = 1;
string address = 2;
string hostname = 3;
}
7 changes: 3 additions & 4 deletions proto/rg.proto
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ option java_generate_equals_and_hash = true;
option csharp_namespace = "Milvus.Client.Grpc";

message ResourceGroupLimit {
int32 nodeNum = 1;
int32 node_num = 1;
// preserve for other limit.
}

Expand All @@ -23,7 +23,6 @@ message ResourceGroupTransfer {
message ResourceGroupConfig {
ResourceGroupLimit requests = 1; // requests node num in resource group, if node num is less than requests.nodeNum, it will be transfer from other resource group.
ResourceGroupLimit limits = 2; // limited node num in resource group, if node num is more than limits.nodeNum, it will be transfer to other resource group.
repeated ResourceGroupTransfer from = 3; // missing node should be transfer from given resource group at high priority in repeated list.
repeated ResourceGroupTransfer to = 4; // redundant node should be transfer to given resource group at high priority in repeated list.
repeated ResourceGroupTransfer transfer_from = 3; // missing node should be transfer from given resource group at high priority in repeated list.
repeated ResourceGroupTransfer transfer_to = 4; // redundant node should be transfer to given resource group at high priority in repeated list.
}

0 comments on commit 8494076

Please sign in to comment.