Make metadata optional. Missed additional review changes (#370)

* Make metadata optional. Not enabled by default * Turn variable into const * Add missed review changes * Bump RC version --------- Co-authored-by: Shivank Dubey <[email protected]>
millicast · Jun 10, 2024 · f7c69c2 · f7c69c2
1 parent 34e405e
commit f7c69c2
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/packages/millicast-sdk/package-lock.json b/packages/millicast-sdk/package-lock.json
diff --git a/packages/millicast-sdk/package.json b/packages/millicast-sdk/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@millicast/sdk",
-  "version": "0.1.45",
+  "version": "0.1.46-RC1",
   "description": "SDK for building a realtime broadcaster using the Millicast platform.",
   "keywords": [
     "sdk",

diff --git a/packages/millicast-sdk/src/Publish.js b/packages/millicast-sdk/src/Publish.js
@@ -201,9 +201,7 @@ export default class Publish extends BaseWebRTC {
       publisherData = await this.tokenGenerator()
       //  Set the iceServers from the publish data into the peerConfig
       this.options.peerConfig.iceServers = publisherData?.iceServers
-      if (this.options.metadata) {
-        this.options.peerConfig.encodedInsertableStreams = supportsInsertableStreams
-      }
+      this.options.peerConfig.encodedInsertableStreams = this.options.metadata
     } catch (error) {
       logger.error('Error generating token.')
       if (error instanceof FetchError) {

diff --git a/packages/millicast-sdk/src/types/index.d.ts b/packages/millicast-sdk/src/types/index.d.ts
@@ -1072,7 +1072,7 @@ declare module '@millicast/sdk' {
      */
     absCaptureTime?: boolean;
     /**
-     * - Enable metadata extraction if stream is compatible.
+     * - Enable metadata extraction. This feature is only supported with the H.264 codec.
      */
     metadata?: boolean;
     /**
@@ -1161,7 +1161,7 @@ declare module '@millicast/sdk' {
      */
     bandwidth?: number;
     /**
-     * - Enable metadata insertion if stream is compatible.
+     * - Enable metadata insertion. This feature is only supported with the H.264 codec.
      */
     metadata?: boolean;
     /**