Clean up some of the vars and loops.
#21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,14 +87,9 @@ RegExp.make = (function () { | |||
| * @this {!CharRanges} | |||
| */ | |||
| CharRanges.prototype.toString = function () { | |||
| var s = ''; | |||
| /** @type {!Array.<number>}. */ | |||
| const ranges = this.ranges; | |||
| /** @type {number} */ | |||
There was a problem hiding this comment.
This needs to go away since you've gotten rid of n.
ljharb
force-pushed
the
patch-1
branch
2 times, most recently
from
cb6dde9
to
0f0c91b
Compare
|
I've updated the diff. In a JS project, cloning and running |
There's zero reason in 2015 to use a loop, or "var" - this cleans some of them up. There's still a bunch left, but I figured I'd tackle just a little bit at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's zero reason in 2015 to use a loop, or "var" - this cleans some of them up.
There's still a bunch left, but I figured I'd tackle just a little bit at a time.