Add input to truncate stack traces in annotations #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates parsing of JUnit tests to conditionally truncate stack traces based on input to the action. Uses the first line of the `message` when logging the path, line, and test duration, in the same manner as `annotateTestResult`. Maintains default behavior to truncate if input is not used.
stackptr
commented
Jan 11, 2024
| @@ -375,7 +381,7 @@ async function parseSuite( | |||
| // fish the time-taken out of the test case attributes, if present | |||
| const testTime = testcase._attributes.time === undefined ? '' : ` (${testcase._attributes.time}s)` | |||
|
|
|||
| core.info(`${resolvedPath}:${pos.line} | ${message.replace(/\n/g, ' ')}${testTime}`) | |||
| core.info(`${resolvedPath}:${pos.line} | ${message.split('\n', 1)[0]}${testTime}`) | |||
There was a problem hiding this comment.
In the event that message is a full stack trace, it seems more polite to just log the first line. This should be the only change that impacts existing users of the action.
|
Thank you very much for your contribution! |
mikepenz
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates parsing of JUnit tests to conditionally truncate stack traces based on input to the action. Uses the first line of the
messagewhen logging the path, line, and test duration, in the same manner asannotateTestResult. Maintains default behavior to truncate if input is not used.Provides a way forward for users encountering #1006