Merge pull request #969 from mikepenz/fix/gracefully_handle_corrupt_f…

…iles Gracefully handle corrupt test files (log error instead of failing)
mikepenz · Oct 20, 2023 · 0831a82 · 0831a82
2 parents 7e43ff9 + c07c04d
commit 0831a82
Show file tree

Hide file tree

Showing 3 changed files with 59 additions and 1 deletion.
diff --git a/__tests__/testParser.test.ts b/__tests__/testParser.test.ts
@@ -1085,4 +1085,32 @@ action.surefire.report.email.InvalidEmailAddressException: Invalid email address
       }
     ])
   })
+
+  it('parse corrupt test output', async () => {
+    const result = await parseTestReports(
+      '',
+      '',
+      'test_results/corrupt-junit/**/target/sf-reports/TEST-*.xml',
+      '',
+      false,
+      false,
+      [],
+      '',
+      '',
+      undefined,
+      false,
+      undefined
+    )
+
+    expect(result).toStrictEqual({
+      checkName: "",
+      summary: "",
+      totalCount: 0,
+      skipped: 0,
+      failed: 0,
+      passed: 0,
+      annotations: [
+      ],
+    })
+  })
 })
diff --git a/src/testParser.ts b/src/testParser.ts
@@ -151,7 +151,19 @@ export async function parseFile(
   core.debug(`Parsing file ${file}`)
 
   const data: string = fs.readFileSync(file, 'utf8')
-  const report = JSON.parse(parser.xml2json(data, {compact: true}))
+
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  let report: any
+  try {
+    report = JSON.parse(parser.xml2json(data, {compact: true}))
+  } catch (error) {
+    core.error(`⚠️ Failed to parse file (${file}) with error ${error}`)
+    return {
+      totalCount: 0,
+      skipped: 0,
+      annotations: []
+    }
+  }
 
   return parseSuite(
     report,

diff --git a/test_results/corrupt-junit/e2e-tests/corrupt/target/sf-reports/TEST-test.CorruptTest.xml b/test_results/corrupt-junit/e2e-tests/corrupt/target/sf-reports/TEST-test.CorruptTest.xml
@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<testsuite xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd" version="3.0" name="corrupt.CorruptTest" time="11.288" tests="1" errors="0" skipped="0" failures="1">
+  <properties>
+    <property name="idea.io.use.nio2" value="true"/>
+    <property name="java.ext.dirs" value="/opt/hostedtoolcache/jdk/8.0.382/x64/jre/lib/ext:/usr/java/packages/lib/ext"/>
+    <property name="java.class.version" value="52.0"/>
+    <property name="ast.loading.filter" value="false"/>
+  </properties>
+  <testcase name="testEM" classname="corrupt.CorruptTest" time="10.131">
+    <failure type="java.lang.AssertionError"><![CDATA[java.lang.AssertionError: WRONG COVERAGE: 41 > 26
+	at corrupt.core.Main$Companion.initAndRun(Main.kt:244)
+	at corrupt.core.Main.initAndRun(Main.kt)
+	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
+	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
+	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
+	at java.lang.Thread.run(Thread.java:750)
+]]></failure>
+    <system-out><![CDATA[