Add Mail.require_silently for parser warnings #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, requiring parsers emitted a number of unused variable and unreachable statement warnings. The unused variable warnings are simple to fix (see 8dd1655), but the unreachable statements do not seem to be. Since it seems like its difficult to make Ragel generated parsers not emit any warnings, this commit adds a helper method that wraps require and silences the warnings emitted. The changes to $VERBOSE in the parsers added in 7ef5694 unfortunately do not help as the warnings are emitted on parse and not when evaluating the files.
skipkayhil
added a commit
to skipkayhil/rails
that referenced
this pull request
Feb 23, 2023
Previously, requiring any of the ragel generated parsers in mail would output tons of warnings in tests, making output much harder to read (especially in Railties). This commit extends the RaiseWarnings patch to suppress output from these mail parsers. The suppression can be removed once mikel/mail#1557 or mikel/mail#1551 or any other PR fixes the issue
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, requiring parsers emitted a number of unused variable and unreachable statement warnings. The unused variable warnings are simple to fix (see skipkayhil/mail@8dd1655), but the unreachable statements do not seem to be.
Since it seems like its difficult to make Ragel generated parsers not emit any warnings, this commit adds a helper method that wraps require and silences the warnings emitted. The changes to $VERBOSE in the parsers added in 7ef5694 unfortunately do not help as the warnings are emitted on parse and not when evaluating the files.
Additional Information
Ref: #1551
If the method is overkill but the approach is reasonable, I can also change this to just add the warning silencing to the individual requires since there are only 16.