Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all 'assigned but unused variable' warnings #1551

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Fix all 'assigned but unused variable' warnings #1551

merged 2 commits into from
Jun 3, 2024

Commits on Dec 23, 2022

  1. rake ragel 

    The formatting differences are likely due to using a newer version of
rufo
    @skipkayhil
    skipkayhil committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    596f06f View commit details
    Browse the repository at this point in the history

  2. Fix all 'assigned but unused variable' warnings 

    - The variables in content_location_parser appear to have been copied
  from content_disposition_parser but are unused
- Ragel seems to always generate a useless testEof variable. The `if
  false` trick is also used in whitequark/parser@21581a2 to suppress the
  warning. As mentioned in the parser commit, `if false` will not
  actually generate instructions and so it has no runtime cost.

Co-authored-by: Guilherme Quirino <[email protected]>
    @skipkayhil @GQuirino
    skipkayhil and GQuirino committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    8dd1655 View commit details
    Browse the repository at this point in the history