include rfc822 as attachments

[ahorek]

the original feature 1e665e4

email -> eml -> png

before

attachments: png

after

attachments: eml, png

I'm not sure what the correct behavior should be. For instance, Thunderbird includes eml as an ordinary attachment but some other clients don't even if Content-Disposition: attachment;. Thoughts?

[tatey]

@ahorek Thanks a tonne for this patch!

I ran into a problem where Mail wouldn't recognise .eml attachments. Before applying your patch.

mail.attachments["foo.eml"] = {mime_type: "message/rfc822", content: "..."}
mail.attachments # => []

And after applying your patch:

mail.attachments["foo.eml"] = {mime_type: "message/rfc822", content: "..."}
mail.attachments # => [..]

Using the attachment? predicate to determine whether or not it should be included in the list makes a tonne of sense.

[brianknight10]

Hello! This patch is great and works well. Is there any reason why it hasn't been merged into a release?

[der-flo]

@mikel @jeremy Is there anything I/we can do to support resolving this issue und releasing a new version of this gem?

[svenwin]

@mikel what's your take on this? What can we do to help you resolve this issue?

[mikel]

Hey there @svenwin @der-flo @brianknight10 @tatey and of course @ahorek - could one of you please get this rebased onto the latest master and I'll review and merge it then.

[ahorek]

sure thing! done

[ahorek]

ping @eval

[eval]

Ported to 2-8-stable

[ahorek]

thanks!