Made sure that the plugin work without "@danielmoncada/angular-datetime-picker": "16.0.1" #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sanioooook
commented
Nov 29, 2023
sanioooook
commented
- Removed references to @danielmoncada/angular-datetime-picker in workflow-case-edit.component.html and workflow-pn.module.ts
- Replaced owlDateTime with matDatepicker in workflow-case-edit.component.html
- Updated event handlers for date selection in workflow-case-edit.component.ts
…e-picker - Removed references to @danielmoncada/angular-datetime-picker in workflow-case-edit.component.html and workflow-pn.module.ts - Replaced owlDateTime with matDatepicker in workflow-case-edit.component.html - Updated event handlers for date selection in workflow-case-edit.component.ts
sanioooook
changed the title
- Refactored the code to use a helper function for selecting dates on the date picker. - Removed unnecessary code related to spinner animation. - Updated the WorkflowCaseForEdit class to use separate properties for year, month, and day instead of a Date object. Edit workflow case test - Updated the test to create a new instance of Date and set it as the value for deadline and dateOfIncident properties in modelForUpdate. - Asserted that the updated values are correctly displayed in the UI.
- Refactored the code to improve readability and maintainability - Introduced a new variable `dateNow` to store the current date - Updated the `deadline` and `dateOfIncident` properties of the `modelForUpdate` object to use separate day, month, and year values instead of a single Date object
- Move selectDateOnDatePicker function to the correct import path - Update usage of selectDateOnDatePicker with correct parameters - Fix date calculation in workflow.edit.ts for dateOfIncident and deadline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.