Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove login hint #267

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Remove login hint #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Microsoft.Graph.Cli.Core/Authentication/AuthenticationServiceFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@

private readonly AuthenticationOptions? authenticationOptions;

public AuthenticationServiceFactory(IPathUtility pathUtility, IAuthenticationCacheManager authenticationCacheManager, AuthenticationOptions? authOptions)

Check warning on line 23 in src/Microsoft.Graph.Cli.Core/Authentication/AuthenticationServiceFactory.cs

View workflow job for this annotation

GitHub Actions / build 

Missing XML comment for publicly visible type or member 'AuthenticationServiceFactory.AuthenticationServiceFactory(IPathUtility, IAuthenticationCacheManager, AuthenticationOptions?)'
{
this.pathUtility = pathUtility;
this.authenticationOptions = authOptions;
this.authenticationCacheManager = authenticationCacheManager;
}

public virtual async Task<LoginServiceBase> GetAuthenticationServiceAsync(AuthenticationStrategy strategy, string? tenantId, string? clientId, string? certificateName, string? certificateThumbPrint, CancellationToken cancellationToken = default)

Check warning on line 30 in src/Microsoft.Graph.Cli.Core/Authentication/AuthenticationServiceFactory.cs

View workflow job for this annotation

GitHub Actions / build 

Missing XML comment for publicly visible type or member 'AuthenticationServiceFactory.GetAuthenticationServiceAsync(AuthenticationStrategy, string?, string?, string?, string?, CancellationToken)'
{
var credential = await GetTokenCredentialAsync(strategy, tenantId, clientId, certificateName, certificateThumbPrint, cancellationToken);
if (strategy == AuthenticationStrategy.DeviceCode && credential is DeviceCodeCredential deviceCred)
Expand Down Expand Up @@ -56,7 +56,7 @@
}
}

public virtual async Task<TokenCredential> GetTokenCredentialAsync(AuthenticationStrategy strategy, string? tenantId, string? clientId, string? certificateName, string? certificateThumbPrint, CancellationToken cancellationToken = default)

Check warning on line 59 in src/Microsoft.Graph.Cli.Core/Authentication/AuthenticationServiceFactory.cs

View workflow job for this annotation

GitHub Actions / build 

Missing XML comment for publicly visible type or member 'AuthenticationServiceFactory.GetTokenCredentialAsync(AuthenticationStrategy, string?, string?, string?, string?, CancellationToken)'
{
switch (strategy)
{
Expand Down Expand Up @@ -103,7 +103,6 @@
TokenCachePersistenceOptions tokenCacheOptions = new() { Name = Constants.TokenCacheName };
credOptions.TokenCachePersistenceOptions = tokenCacheOptions;
credOptions.AuthenticationRecord = await authenticationCacheManager.ReadAuthenticationRecordAsync(cancellationToken);
credOptions.LoginHint = credOptions.AuthenticationRecord?.Username;

return new InteractiveBrowserCredential(credOptions);
}
Expand Down
Loading