-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore/tasks linting #2176
chore/tasks linting #2176
Conversation
dcb0d98
to
094f517
Compare
@irvinesunday @thewahome @millicentachieng Some additional context here:
When you review I suggest that:
Let me know if you have any additional comments or questions. |
06e9887
to
bc8f6ef
Compare
b316563
to
e1b3a09
Compare
@baywet The snippets pipeline is failing due to timeouts. Further investigation is needed to resolve the underlying issue. |
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
…roved readability
812ee47
to
d104dd2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort here @baywet.
We'll still need to run some validations on this before merging as you suggested. Otherwise, just a few comments from my side.
CodeSnippetsReflection.OpenAPI/CodeSnippetsReflection.OpenAPI.csproj
Outdated
Show resolved
Hide resolved
b5ae25e
to
e8a9e22
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling auto-merge for now so that @millicentachieng can take a look before we finally merge.
Quality Gate failedFailed conditions |
Microsoft Reviewers: Open in CodeFlow