Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: Icedrive.Icedrive version 2.29.9 #39191

Closed
wants to merge 1 commit into from
Closed

New package: Icedrive.Icedrive version 2.29.9 #39191

wants to merge 1 commit into from

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Dec 29, 2021 •
edited
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Closing these issues in favor of #39190

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 29, 2021
@ghost
Copy link

ghost commented Dec 29, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Dec 29, 2021

@Trenly,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 29, 2021
@ghost
Copy link

ghost commented Dec 29, 2021

Hello @Trenly,
Validation has completed.

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Dec 29, 2021
@ghost
Copy link

ghost commented Dec 29, 2021

Hello @Trenly,
Validation has completed.

@ghost
Copy link

ghost commented Dec 29, 2021

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

SpecterShell pushed a commit to SpecterShell/winget-pkgs that referenced this pull request Dec 29, 2021
@Trenly
New package: Icedrive.Icedrive version 2.29.9 (microsoft#39191)
c20ad08
@Trenly Trenly closed this Dec 29, 2021
@Trenly Trenly reopened this Dec 29, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Dec 29, 2021
@Trenly Trenly closed this Dec 29, 2021
@Trenly Trenly reopened this Dec 29, 2021
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Dec 29, 2021

@denelon - I realize it's holidays for you guys, but is there someone available who can merge this?

@ghost ghost removed Validation-Completed Validation passed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. labels Dec 29, 2021
@ghost
Copy link

ghost commented Dec 29, 2021

Hello @Trenly,
The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

@ghost ghost added Needs-Author-Feedback This needs a response from the author. and removed PullRequest-Error PR is Invalid labels Dec 29, 2021
@ghost
Copy link

ghost commented Dec 29, 2021

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

1 similar comment
@ghost
Copy link

ghost commented Dec 29, 2021

Apologies, I am afraid I am encountering technical difficulties that might have hampered my ability to assist with merging this pull request. I will continue to try to assist if there are further changes to this pull request.

@Trenly Trenly closed this Dec 29, 2021
@Trenly Trenly reopened this Dec 29, 2021
@ghost ghost removed the Needs-Author-Feedback This needs a response from the author. label Dec 29, 2021
OfficialEsco pushed a commit to OfficialEsco/winget-pkgs that referenced this pull request Dec 29, 2021
@Trenly
New package: Icedrive.Icedrive version 2.29.9 (microsoft#39191)
76b2877
OfficialEsco pushed a commit to OfficialEsco/winget-pkgs that referenced this pull request Dec 29, 2021
@Trenly
New package: Icedrive.Icedrive version 2.29.9 (microsoft#39191)
353a337
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Dec 29, 2021
@ghost
Copy link

ghost commented Dec 29, 2021

Hello @Trenly,
The package manager bot determined there was an issue with the pull request. Make sure the manifest files are under the manifests\partition\publisher\appname\version directory. The partition of the path must be the first letter of the publisher in lower-case.

Example:
Path: manifests / m / Microsoft / WindowsTerminal / 1.6.10571.0 / WindowsTerminal.yaml

For details on the error, see the details link below in the build pipeline.

You may also try the Windows Package Manager Manifest Creator

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Dec 29, 2021
@OfficialEsco
Copy link
Contributor

@arjun-msft you seem to be alive at this hour, i think we broke stuff 👀

@Trenly
Copy link
Contributor Author

Trenly commented Dec 29, 2021

@arjun-msft you seem to be alive at this hour, i think we broke stuff 👀

I think that the commits merged in, just that the sheer number of issues to be closed caused the bot to not actually close anything. I think all the issues mentioned above can be closed, and then this PR can be marked as closed

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 29, 2021
@vedantmgoyal9
Copy link
Contributor

Adding a dummy commit then force-pushing the branch should fix the issue, I guess.

@Trenly
Copy link
Contributor Author

Trenly commented Dec 29, 2021

Adding a dummy commit then force-pushing the branch should fix the issue, I guess.

It shouldnt because it should still recognize that the previous commits were already merged in, and return the same PR validation error. I don’t want to break anything further, so I’ll let MSFT fix it first

@ghost
Copy link

ghost commented Dec 29, 2021 •
edited by ghost
Loading

Ran into the same issue; looks like @msftbot merges in the commit instead of merging the PR for trying to close 10+ issues/PRs.

#39239 (comment)

So I'm just going to delete everything from my PR message.

Adding a dummy commit then force-pushing the branch should fix the issue, I guess.

Since the commit was merged the PR will get Internal-Error-Webhook because nothing was changed. Something like this: #36945

@Trenly Trenly closed this Dec 29, 2021
@Trenly Trenly deleted the Icedrive.Icedrive-2.29.9-9DBC3FA branch December 29, 2021 16:31
@OfficialEsco OfficialEsco mentioned this pull request Dec 29, 2021
Closed
5 tasks
@arjun-msft
Copy link
Member

@OfficialEsco did this make it in? I see it closed but I don't think it got merged but I see it in the repo. Let me know if something needs to be done!

@OfficialEsco
Copy link
Contributor

It got merged 3 times actually, however it never said it merged it or closed the PR or any of the issues
c20ad08
76b2877
353a337
But i think everything is fine and dandy + we found a workaround for the PRs
Would you mind closing #38852 since its resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OfficialEsco OfficialEsco OfficialEsco approved these changes

Assignees
No one assigned
Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. PullRequest-Error PR is Invalid
Projects
None yet
Milestone
No milestone
5 participants
@Trenly @wingetbot @OfficialEsco @vedantmgoyal9 @arjun-msft