Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows settings language #91

Closed
wants to merge 47 commits into from

Conversation

Gijsreyn
Copy link
Contributor

@Gijsreyn Gijsreyn commented Nov 4, 2024


Addresses the Microsoft.Windows.Setting.Language on #34 and #92.

Note

I recognize it has a bit more in the pull request (e.g. the New-DscResourceModule script). I added this script to help others get started and set standard information when a new module is introduced.

@Gijsreyn Gijsreyn marked this pull request as ready for review November 4, 2024 06:47
@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Nov 4, 2024

Hi @denelon and @stephengillie, I saw a pretty astonishing list on #34 so I thought of helping out. I didn't want to step on anyones toes, nor hijack any work. Hope you don't mind.

I've put the state to review. However, there are two TODOs in the module itself that raised some questions. You mind taking a look and provide feedback? Thanks!

This comment has been minimized.

This comment has been minimized.

@stephengillie
Copy link
Collaborator

Hi @Gijsreyn,

Thank you for your help and sorry for the delay in responding. I'm dealing with capacity issues.

This is a large change, adding and modifying numerous files, and modifies both documentation and code. Could the documentation changes be moved to another PR? That would make those changes more clear and easier to review, while allowing this PR to be focused on the DSC resource code.

@Gijsreyn
Copy link
Contributor Author

Gijsreyn commented Nov 7, 2024

@stephengillie No worries there. I think the tip from Josh on #89 to rebase shouldn't have it made that large. Sorry, have to upgrade my Git skills a bit. Always following to much of a standard approach on things. I'm closing this one and try to give it another shot.

@Gijsreyn Gijsreyn closed this Nov 7, 2024
@Trenly
Copy link
Contributor

Trenly commented Nov 7, 2024

Another practice I've taken on is to set my git config to allow fast-forward only, that way only clean merges can happen. If a merge isn't clean, It will force me to either confirm that it can’t merge cleanly (using --no-ff) or I'll have to rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants