Use malloc on non-Windows platforms #3095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riverar
reviewed
Jun 12, 2024
riverar
approved these changes
Jun 12, 2024
|
Cool! |
|
Oh wait, I was wrong. There's still a bunch of other symbols that I'll need to deal with, for DWriteCore. Like all of the VARIANT conversions that call into external functions. Still, this PR gets me one step closer. |
kennykerr
approved these changes
Jun 13, 2024
|
@sivadeilra I think we could eliminate those VariantToProp/PropToVariant conversion functions altogether and just do the conversions ourselves (being careful to copy strings, convert filetimes, handle clsids, etc.). Or maybe a smaller step would be to just cfg! them away and see if anyone even needs them. |
mati865
pushed a commit
to mati865/windows-rs
that referenced
this pull request
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of fixing #3083 . This allows non-Windows code to use more of the COM support from
windows-core.This changes the
heap_allocfunction (and related) to usemallocon non-Windows platforms, instead ofHeapAlloc.With this change, I can now build DWriteCore using
windows-rscrates.