Optimize IUnknown identity checks
#3073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivadeilra
force-pushed
the
user/ardavis/iunknown-qi-tests
branch
from
ab3c426 to
460803d
Compare
kennykerr
reviewed
Jun 6, 2024
kennykerr
reviewed
Jun 6, 2024
kennykerr
changed the title
IUnknown identity checks
kennykerr
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3069 by adding more coverage for IUnknown identity tests.
This also adds a fast-path for comparing interface identity. If two COM interface pointers have the same pointer view, then they refer to the same object and we can avoid the QueryInterface calls.