Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable unexpected_cfgs #3050

Merged
merged 2 commits into from
May 22, 2024
Merged

Conversation

ChrisDenton
Copy link
Collaborator

This is an attempt to re-enable unexpected_cfgs using the new unexpected_cfgs config in Cargo.toml. This avoids the need for a build script while still checking for typos in global cfgs.

@ChrisDenton
Copy link
Collaborator Author

Hm, looks like it isn't enough to just add it to the workspace lint table.

@kennykerr
Copy link
Collaborator

Well that's less bad. 🥲 Thanks Chris!

@kennykerr kennykerr merged commit 92ecfbd into microsoft:master May 22, 2024
89 checks passed
@ChrisDenton ChrisDenton deleted the unexpected_cfgs branch May 22, 2024 13:59
@kennykerr
Copy link
Collaborator

Hmm, noticing a bunch of warnings in local builds now.

warning: D:\git\windows-rs\crates\tests\calling_convention\Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
warning: D:\git\windows-rs\crates\tests\debugger_visualizer\Cargo.toml: unused manifest key: lints.rust.unexpected_cfgs.check-cfg
warning: D:\git\windows-rs\Cargo.toml: unused manifest key: workspace.lints.rust.unexpected_cfgs.check-cfg

Looks like this is only on stable and goes away on nightly. Is that expected?

@ChrisDenton
Copy link
Collaborator Author

Oh. Hm. Looks like this is expected on stable. A fix to silence the warnings was backported to beta but not current stable. So it will be an issue until the next release.

mati865 pushed a commit to mati865/windows-rs that referenced this pull request Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants